fix: default host when empty#63
Merged
marandaneto merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
tests/PostHog.Unity.Tests/PostHogConfigTests.cs:67-84
**Prefer a parameterised theory + add whitespace case**
The team rule prefers `[Theory]` over repeating near-identical `[Fact]` tests. The two new facts share identical structure and could be a single theory. Additionally, `Validate()` uses `IsNullOrWhiteSpace`, so a whitespace-only host is also defaulted, but there is no test covering that case (while the analogous `WithWhitespaceApiKey_ThrowsArgumentException` test exists for `ApiKey`).
Reviews (1): Last reviewed commit: "fix: default host when empty" | Re-trigger Greptile |
turnipdabeets
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
PostHogConfigalready defaultsHostwhen omitted, but explicitly setting it tonullor an empty value caused validation to fail. This keeps host configuration optional by falling back to the default PostHog host for blank values.💚 How did you test it?
DOTNET_ROLL_FORWARD=Major dotnet test tests/PostHog.Unity.Tests/PostHog.Unity.Tests.csproj --no-restore📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset filereleaselabel to the PR