Skip to content

Refactor some base Funnel query components #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neilkakkar merged 9 commits into from
Jul 8, 2021
Merged

Refactor some base Funnel query components #5037

neilkakkar merged 9 commits into from
Jul 8, 2021

Conversation

@neilkakkar
Copy link
Contributor

@neilkakkar neilkakkar commented Jul 8, 2021

Changes

Clean up 🤵 ✂️

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar neilkakkar requested review from EDsCODE and Twixes July 8, 2021 10:40
@timgl timgl temporarily deployed to posthog-pr-5037 July 8, 2021 10:41 Inactive
@timgl timgl temporarily deployed to posthog-pr-5037 July 8, 2021 10:52 Inactive
EDsCODE
EDsCODE approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from mixnmatch to master July 8, 2021 16:38
@neilkakkar neilkakkar enabled auto-merge (squash) July 8, 2021 16:58
@timgl timgl temporarily deployed to posthog-pr-5037 July 8, 2021 17:16 Inactive
Twixes
Twixes approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neilkakkar neilkakkar merged commit 7954477 into master Jul 8, 2021
@neilkakkar neilkakkar deleted the refactor branch July 8, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Twixes Twixes Twixes approved these changes

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neilkakkar @Twixes @EDsCODE @timgl