fix(product-tours): use dedicated color instead of borrowing surveys color#53329
Draft
posthog[bot] wants to merge 1 commit intomasterfrom
Draft
fix(product-tours): use dedicated color instead of borrowing surveys color#53329posthog[bot] wants to merge 1 commit intomasterfrom
posthog[bot] wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Size Change: +576 B (0%) Total Size: 128 MB ℹ️ View Unchanged
|
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
adboio
reviewed
Apr 7, 2026
| --color-product-dashboards-light: rgb(255 139 7); | ||
| --color-product-early-access-features-light: rgb(39 171 151); | ||
| --color-product-early-access-features-dark: rgb(53 213 189); | ||
| --color-product-product-tours-light: rgb(255 106 61); |
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: frontend/src/styles/base.scss
Line: 350
Comment:
**Unused dark CSS variable**
`--color-product-product-tours-dark` is defined here but never referenced anywhere in the codebase. Other products that define both light and dark variants (e.g. `early_access_features`, `replay`, `revenue_analytics`) use both in their manifest `iconColor` arrays:
```
// e.g. early_access_features/manifest.tsx
iconColor: [
'var(--color-product-early-access-features-light)',
'var(--color-product-early-access-features-dark)',
]
```
The product tours manifest currently only passes a single-element array `['var(--color-product-product-tours-light)']`. Either remove the unused dark variable to avoid dead code, or wire it into all three `iconColor` arrays in `manifest.tsx` to stay consistent with the established two-tone pattern.
```suggestion
--color-product-product-tours-light: rgb(255 106 61);
```
(If intentionally deferring dark mode support, simply removing the dark variable avoids dead code.)
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(product-tours): use dedicated color ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| --color-product-early-access-features-light: rgb(39 171 151); | ||
| --color-product-early-access-features-dark: rgb(53 213 189); | ||
| --color-product-product-tours-light: rgb(255 106 61); | ||
| --color-product-product-tours-dark: rgb(255 130 92); |
Contributor
There was a problem hiding this comment.
--color-product-product-tours-dark is defined here but never referenced anywhere in the codebase. Other products that define both light and dark variants (e.g. early_access_features, replay, revenue_analytics) use both in their manifest iconColor arrays:
// e.g. early_access_features/manifest.tsx
iconColor: [
'var(--color-product-early-access-features-light)',
'var(--color-product-early-access-features-dark)',
]
The product tours manifest currently only passes a single-element array ['var(--color-product-product-tours-light)']. Either remove the unused dark variable to avoid dead code, or wire it into all three iconColor arrays in manifest.tsx to stay consistent with the established two-tone pattern.
Suggested change
| --color-product-product-tours-dark: rgb(255 130 92); | |
| --color-product-product-tours-light: rgb(255 106 61); |
(If intentionally deferring dark mode support, simply removing the dark variable avoids dead code.)
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/styles/base.scss
Line: 350
Comment:
**Unused dark CSS variable**
`--color-product-product-tours-dark` is defined here but never referenced anywhere in the codebase. Other products that define both light and dark variants (e.g. `early_access_features`, `replay`, `revenue_analytics`) use both in their manifest `iconColor` arrays:
```
// e.g. early_access_features/manifest.tsx
iconColor: [
'var(--color-product-early-access-features-light)',
'var(--color-product-early-access-features-dark)',
]
```
The product tours manifest currently only passes a single-element array `['var(--color-product-product-tours-light)']`. Either remove the unused dark variable to avoid dead code, or wire it into all three `iconColor` arrays in `manifest.tsx` to stay consistent with the established two-tone pattern.
```suggestion
--color-product-product-tours-light: rgb(255 106 61);
```
(If intentionally deferring dark mode support, simply removing the dark variable avoids dead code.)
How can I resolve this? If you propose a fix, please make it concise.…tours Add coral-orange CSS variables (light + dark) for product tours and update manifest iconColor arrays to use both variants, replacing the borrowed surveys color.
posthog
Bot
force-pushed
the
fix/product-tours-color
branch
from
58bbae1 to
dfb7876
Compare
Contributor
Storybook visual regression tests failedIf your changes intentionally update UI snapshots: add the If you didn't change any UI: this is likely a flaky snapshot — wait for a fix to land on master. |
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Product tours was borrowing
var(--color-product-surveys-light)(red) for its icon color across the file system tree, new item menu, and products sidebar. This made it visually indistinguishable from surveys.Changes
--color-product-product-tours-light(rgb(255 106 61)) and--color-product-product-tours-dark(rgb(255 130 92)) — a vibrant coral-orange that's unique in the product paletteproducts/product_tours/manifest.tsxto reference the new variable in all threeiconColordeclarationsHow did you test this code?
This is a CSS variable + manifest reference change. Verified that:
iconColorreferences in the manifest are updatedPublish to changelog?
No
Docs update
N/A
LLM context
Agent-authored PR. Searched for all product tour color references, added dedicated CSS variables, and updated the manifest.