Skip to content

Allow mix-n-matching Funnel types in cache update #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neilkakkar merged 4 commits into from
Aug 2, 2021
Merged

Allow mix-n-matching Funnel types in cache update #5399

neilkakkar merged 4 commits into from
Aug 2, 2021

Conversation

@neilkakkar
Copy link
Contributor

@neilkakkar neilkakkar commented Jul 30, 2021

Changes

Follow up to #5051 - it's not a problem yet, but would've been once support for different orderings is introduced.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar neilkakkar requested review from EDsCODE and Twixes July 30, 2021 13:39
@neilkakkar neilkakkar changed the title Allow mix-n-matching in cache update Allow mix-n-matching Funnel types in cache update Jul 30, 2021
@timgl timgl temporarily deployed to posthog-pr-5399 July 30, 2021 13:41 Inactive
Twixes
Twixes reviewed Aug 2, 2021
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Do we have caching tests for this though?

@neilkakkar
Copy link
Contributor Author

neilkakkar commented Aug 2, 2021

Nope, I'm guessing that's why things were passing before as well. Will add them here :)

@timgl timgl temporarily deployed to posthog-pr-5399 August 2, 2021 14:02 Inactive
@timgl timgl temporarily deployed to posthog-pr-5399 August 2, 2021 14:12 Inactive
@neilkakkar neilkakkar requested a review from Twixes August 2, 2021 16:17
@neilkakkar neilkakkar merged commit 73d85c9 into master Aug 2, 2021
@neilkakkar neilkakkar deleted the cache_update branch August 2, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Twixes Twixes Twixes approved these changes

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neilkakkar @Twixes @timgl