Some Paths fixes for Start/End Buttons #6175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
reviewed
Sep 29, 2021
| </span> | ||
| {humanFriendlyDuration( | ||
| pathItemCard.targetLinks[0].average_conversion_time | ||
| pathItemCard.targetLinks[0].average_conversion_time / 1000 |
Collaborator
There was a problem hiding this comment.
was this the wrong unit before?
Contributor
Author
There was a problem hiding this comment.
Correct. 6 hours average time on Paths makes no sense 😂 .
EDsCODE
approved these changes
Sep 29, 2021
Collaborator
EDsCODE
left a comment
EDsCODE
left a comment
There was a problem hiding this comment.
looks good. i'll work on the fix for the covered close button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Part of #6157
How did you test this code?
Manually: See that the UI looks good when running locally