Campaign Fixes

[Ebube111]

• Fixed start date bug in create campaign
• Added More edge cases

Summary by CodeRabbit

• Refactor
  • Improved campaign form handling for a smoother user experience.
  • Updated scheduling logic to accept start times that are either current or in the future, providing greater flexibility in campaign creation.
  • Enhanced validation to ensure only valid future dates are accepted, leading to more reliable scheduling.
  • Introduced a new date handling library for improved date accuracy.
  • These refinements deliver improved accuracy and robustness in managing campaign timings.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
potlock-next-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 26, 2025 6:12pm

[coderabbitai]

Walkthrough

This pull request makes targeted adjustments to the campaign-related components and hooks. In the CampaignForm component, the useEffect dependency array is updated by removing the form dependency. In the useCampaignForm hook, the condition for including the start_ms field has been modified, and a new Temporal import has been added. Additionally, the campaign schema now features enhanced validation for the start_ms and end_ms fields to ensure the provided timestamps are in the future.

Changes

File(s)	Change Summary
src/.../CampaignForm.tsx	Added Temporal library for date handling, removed formatTimestampForInput function, updated useEffect to set start_ms and end_ms directly, and modified rendering of timestamp fields.
src/.../forms.ts, src/.../schema.ts	In forms.ts, adjusted the timeToMilliseconds parameter type from string to number, modified the condition for including start_ms in args, and added a Temporal import. In schema.ts, replaced start_ms and end_ms with futureTimestamp for refined validation and added an import for futureTimestamp.

Possibly related PRs

• Campaign UI fixes #350: Related to modifications in the timeToMilliseconds function's parameter type, focusing on updates to date handling in campaign forms.
• Additional Campaign Fixes #346: Shares a connection with changes in the onSubmit function's logic regarding the handling of the start_ms field in the useCampaignForm hook.
• Fix Campaign Issues #341: Addresses updates to the CampaignForm component, specifically related to handling campaignId, which is also reflected in the changes to the useCampaignForm hook.

Suggested reviewers

• carina-akaia

Poem

I'm a rabbit in the code, quick on my feet,
Hopping through hooks and forms, making changes neat.
Removed a dependency here, adjusted a condition there,
Validating future timestamps with meticulous care.
With a joyful hop and a playful beat, I celebrate every line so sweet!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b414f75 and 7d6a1cf.

📒 Files selected for processing (3)

• src/entities/campaign/components/CampaignForm.tsx (4 hunks)
• src/entities/campaign/hooks/forms.ts (3 hunks)
• src/entities/campaign/models/schema.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• src/entities/campaign/models/schema.ts
• src/entities/campaign/components/CampaignForm.tsx
• src/entities/campaign/hooks/forms.ts

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

src/entities/campaign/models/schema.ts (1)

5-5: Unused import detected.

The futureTimestamp function is imported but not used in this file. Consider removing it if it's not needed.

-import { futureTimestamp } from "@/common/lib";

src/entities/campaign/hooks/forms.ts (2)

6-6: Unused import detected.

The Temporal import from temporal-polyfill is added but not used in the code shown. Consider removing it if it's not needed.

-import { Temporal } from "temporal-polyfill";

---

155-159: Good enhancement to the start date logic.

This change ensures that the start_ms field is only included in the submission if it's in the future or equal to the current time, which aligns with the schema validation. This fixes the start date bug mentioned in the PR description.

However, consider adding error handling around timeToMilliseconds to handle invalid date formats:

 const timeToMilliseconds = (time: string) => {
+  if (!time) return 0;
+  const timestamp = new Date(time).getTime();
+  return isNaN(timestamp) ? 0 : timestamp;
-  return new Date(time).getTime();
 };

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fad62f6 and 9d739ff.

📒 Files selected for processing (3)

• src/entities/campaign/components/CampaignForm.tsx (1 hunks)
• src/entities/campaign/hooks/forms.ts (2 hunks)
• src/entities/campaign/models/schema.ts (2 hunks)

🔇 Additional comments (2)

src/entities/campaign/components/CampaignForm.tsx (1)

63-63: Good fix for preventing unnecessary rerenders.

Removing form from the useEffect dependency array prevents the form values from being reset when the form state changes. This preserves user input once the form is initially populated from existing data.

src/entities/campaign/models/schema.ts (1)

18-28: Great addition of start date validation.

This validation enhancement ensures that campaign start dates must be in the future, which directly addresses the bug mentioned in the PR description. This prevents users from creating campaigns with invalid start dates.