Add pass-through trace format to dsc so that child-processes get traced appropriately by top process
#541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
force-pushed
the
trace-envvar
branch
from
4c52728 to
6360c52
Compare
tgauth
approved these changes
Sep 12, 2024
anmenaga
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously traces were rendered by child
dscprocesses which polluted the output and trace level didn't match what the user requested as they would be written attracelevel only.Change is to add a
pass-throughformat which also makes childdscnot trace the output but instead write the JSON to stderr.The top most
dscprocess will deserialize the JSON and write the traces with the appropriate trace level and also include the child process id to get a better idea of the process tree.Also update the tree-sitter build script to not do a clean install of node modules unless running in ADO as it's way too slow.
Example with just INFO level:
Context
Fix #512