Fix adapter configuration set which returns result, but needs to be resources
#774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
force-pushed
the
implicit-ps-set
branch
from
92793c6 to
4f95da2
Compare
tgauth
reviewed
May 1, 2025
Co-authored-by: Tess Gauthier <tgauth@bu.edu>
tgauth
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The problem is that using PS Adapter implicitly means the engine dynamically creates a new configuration that wraps the resource with appropriate adapter (PS7 or WinPS5.1). This gets run which works fine. However, a part of
setalso performs agetto get thebefore_state. Agetreturns the payload asresult, however, the actualbefore_stateas defined in the configuration isresources. So the fix is to address this situation wherebefore_stateneeds to be retrieved at runtime and make it look like a correctsetresponse.