Skip to content

Conversation

@davetapley
Copy link

@davetapley davetapley commented May 18, 2021

PR Summary

Fix #2453

Make ctrl+r in Vi EditMode same as Windows (#2453)

Existing functionality (ViSearchHistoryBackward, SearchForward) already available via / and ? shortcuts.
But ReverseSearchHistory and ForwardSearchHistory had no shortcuts.

Also copy ctrl+s and ctrl+g since these have no conflicts in vi mode.

Remove vi mode existing tests and copy (almost) verbatim from InteractiveHistorySearch to VIInteractiveHistorySearch.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
Microsoft Reviewers: Open in CodeFlow

@davetapley davetapley changed the title Make Ctrl+R in Vi EditMode same as Windows (#2453) Make Ctrl+R in Vi EditMode same as Windows May 21, 2021
@daxian-dbw daxian-dbw closed this Jan 12, 2022
@daxian-dbw
Copy link
Member

@davetapley I made some updates to the tests, but when pushing my changes to your branch, I accidentally pushed my master branch to your fork, because you were using the master branch for this PR. That caused this PR to be closed.
I opened #3148 instead, with your original first commit, and will have that one merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Set-PSReadlineOption -EditMode vi" breaks Ctrl+r / bck-i-search

2 participants