0005 - Add ADR about access rules for Symfony controllers#1
Closed
matks wants to merge 2 commits intoPrestaShop:masterfrom
Closed
0005 - Add ADR about access rules for Symfony controllers#1matks wants to merge 2 commits intoPrestaShop:masterfrom
matks wants to merge 2 commits intoPrestaShop:masterfrom
Conversation
| ## Consequences | ||
|
|
||
| We need to update all controllers already built so they follow this rule. | ||
| We need to make sure controllers that will be added will follow this rule. |
Member
There was a problem hiding this comment.
This should be reflected in an issue in the prestashop specs repository and linked here.
Member
There was a problem hiding this comment.
An issue, specs are to be written by @PrestaShop/prestashop-product-team
There was a problem hiding this comment.
@matks @eternoendless We need more information and context to be able to write specs
Member
There was a problem hiding this comment.
That information should be provided in said issue 🙂
Member
|
0001 should be in a separate PR, shouldn't it? |
Contributor
Author
sarjon
reviewed
Jan 23, 2019
matks
force-pushed
the
add-ADR-about-access-rules-for-sf-controllers
branch
from
a46cdc7 to
fc12af9
Compare
Contributor
Author
|
PR updated with feedbacks handled |
eternoendless
approved these changes
Jan 23, 2019
eternoendless
suggested changes
Jan 23, 2019
| ## Consequences | ||
|
|
||
| We need to update all controllers already built so they follow this rule. | ||
| We need to make sure controllers that will be added will follow this rule. |
Member
There was a problem hiding this comment.
Suggested change
| We need to make sure controllers that will be added will follow this rule. | |
| We need to make sure controllers that will be added will follow this rule (see [issue](https://github.com/PrestaShop/prestashop-specs/issues/1)). |
| We need to update all controllers already built so they follow this rule. | ||
| We need to make sure controllers that will be added will follow this rule. | ||
|
|
||
| See issue https://github.com/PrestaShop/PrestaShop/issues/12270 |
Member
There was a problem hiding this comment.
Suggested change
| See issue https://github.com/PrestaShop/PrestaShop/issues/12270 |
| We need to make sure controllers that will be added will follow this rule. | ||
|
|
||
| See issue https://github.com/PrestaShop/PrestaShop/issues/12270 | ||
| See specs https://github.com/PrestaShop/prestashop-specs/issues/1 |
Member
There was a problem hiding this comment.
Suggested change
| See specs https://github.com/PrestaShop/prestashop-specs/issues/1 |
…define-acl-rules-for-symfony-pages.md
eternoendless
changed the title
Contributor
Author
|
ADR process is heavy and costly so I close this PR as the cost/benefit factor is not high enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.