Skip to content

0019 - Create FQCN Autowiring#29

Merged
matks merged 5 commits intomasterfrom
FabienPapet-patch-1
Nov 16, 2022
Merged

0019 - Create FQCN Autowiring#29
matks merged 5 commits intomasterfrom
FabienPapet-patch-1

Conversation

@FabienPapet
Copy link
Copy Markdown
Member

@FabienPapet FabienPapet commented Nov 8, 2022

This PR follows discussion started in #28

Votes

Vote

Maintainer Vote (✅ or ❌)
@atomiix
@eternoendless ✅ (#28 (comment))
@jolelievre
@kpodemski
@matks
@matthieu-rolland ✅ (#28 (comment))
@NeOMakinG
@PululuK
@sowbiba ✅️

@FabienPapet FabienPapet changed the title Create FQCN Autoriwing Create FQCN Autowiring Nov 8, 2022
@FabienPapet FabienPapet marked this pull request as ready for review November 8, 2022 16:16
@FabienPapet FabienPapet changed the title Create FQCN Autowiring 0019 - Create FQCN Autowiring Nov 8, 2022
@NeOMakinG
Copy link
Copy Markdown

Blank one, trusting my mates on this

@jolelievre
Copy link
Copy Markdown
Contributor

Since 2 / 3 of the maintainers approved this ADR it is now accepted.

Comment thread 0019-FQCN-Autowiring.md Outdated
@matks
Copy link
Copy Markdown
Contributor

matks commented Nov 16, 2022

Thank you everyone

@matks matks merged commit 9c08d00 into master Nov 16, 2022
@matks matks deleted the FabienPapet-patch-1 branch November 16, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.