Skip to content

add hookActionValidateOrder concrete use case example#1543

Closed
PululuK wants to merge 4 commits intoPrestaShop:8.xfrom
PululuK:hook-example-actionValidateOrder
Closed

add hookActionValidateOrder concrete use case example#1543
PululuK wants to merge 4 commits intoPrestaShop:8.xfrom
PululuK:hook-example-actionValidateOrder

Conversation

@PululuK
Copy link
Member

@PululuK PululuK commented Oct 10, 2022

Questions Answers
Branch? 8.x
Description? add hookActionValidateOrder concrete use case example
Fixed ticket? Fixes #1539

Copy link
Contributor

@thomasnares thomasnares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PululuK , just some suggestions of wording corrections. Thanks 👍

PululuK and others added 3 commits October 11, 2022 10:06
Co-authored-by: Thomas NARES <thomasnares@gmail.com>
Co-authored-by: Thomas NARES <thomasnares@gmail.com>
Co-authored-by: Thomas NARES <thomasnares@gmail.com>
@kpodemski
Copy link
Contributor

Hello @PululuK

My opinion is that having examples on this page is too much. We could think of a more advanced module showing the implementation of many hooks, to which we could later link.

It is probably something that @thomasnares and @eternoendless should decide on.

I agree that having more real-life examples could be beneficial for developers. I was thinking of some recepies somewhere in the docs. Another option is to continue working on the example-modules repository.

@kpodemski
Copy link
Contributor

Hi @PululuK

As you know, @thomasnares improved documentation to have such examples on separate pages. This is yours:
https://devdocs.prestashop-project.org/8/modules/sample-modules/example-hooks/actionvalidateorder/

I hope this can unblock your challenge 😎

@kpodemski kpodemski closed this Nov 4, 2022
@PululuK PululuK deleted the hook-example-actionValidateOrder branch November 4, 2022 14:16
@PululuK
Copy link
Member Author

PululuK commented Nov 4, 2022

Thanks @kpodemski @thomasnares !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hooks implementations example

3 participants