Move configuration into its own category & add list of configurations#1544
Merged
kpodemski merged 3 commits intoPrestaShop:8.xfrom Nov 4, 2022
Merged
Move configuration into its own category & add list of configurations#1544kpodemski merged 3 commits intoPrestaShop:8.xfrom
kpodemski merged 3 commits intoPrestaShop:8.xfrom
Conversation
Member
eternoendless
commented
Oct 11, 2022
eternoendless
commented
| Questions | Answers |
|---|---|
| Branch? | 8.x |
| Description? | Moved the configuration into its own category and added the list of all configurations as found in configuration.xml (list to be completed with more data though) |
| Fixed ticket? | Partial fix for #378 |
thomasnares
reviewed
Oct 12, 2022
Contributor
|
@eternoendless @kpodemski do you want me to dive deeper and describe all the settings in the table ? |
Member
Author
Eventually, yes! But I was thinking that we can merge this as it is and improve it later. Finding what each setting does might take a long while. |
Contributor
|
Yes, sure we can merge as it, and improve later |
thomasnares
approved these changes
Oct 12, 2022
kpodemski
reviewed
Oct 13, 2022
eternoendless
force-pushed
the
move-configuration
branch
from
8aa1a26 to
631e419
Compare
kpodemski
approved these changes
Nov 4, 2022
Contributor
kpodemski
left a comment
kpodemski
left a comment
There was a problem hiding this comment.
Let's merge it as is. I'll make sure to check what's going on with the Smarty debug mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.