Fea add action router#10
Open
cdesiles wants to merge 2 commits intoPrestaShopCorp:masterfrom
Open
Conversation
953b2bc to
2e15ec9
Compare
| run: | | ||
| echo "Pulled docker image: $(docker pull --quiet php:${{ inputs.php-version }})" | ||
| docker run --rm --entrypoint /bin/sh php:${{ inputs.php-version }} -c "! (find . -type f -name \"*.php\" ${{ inputs.folder-to-exclude }} -exec php -l -n {} \; | grep -v \"No syntax errors detected\")" | ||
| echo "No syntax error detected" |
Contributor
There was a problem hiding this comment.
What happens if a syntax error is found? will this message be displayed anyway?
Author
There was a problem hiding this comment.
I don't think so, run will fail.
Author
There was a problem hiding this comment.
But you're right we should try this case.
Author
There was a problem hiding this comment.
git ls-files | grep -E '.*\.(php)' | xargs -n1 php -l -n | (! grep -v "No syntax errors" )seems to provide exactly what's needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new agnostic way of linting php.
To test it out: