Skip to content

wraped in try except#38

Closed
ved1beta wants to merge 3 commits intoPrimeIntellect-ai:mainfrom
ved1beta:abort_error
Closed

wraped in try except#38
ved1beta wants to merge 3 commits intoPrimeIntellect-ai:mainfrom
ved1beta:abort_error

Conversation

@ved1beta
Copy link
Copy Markdown

fixes #34
i tried wrapping everything in try except for abort error handling if there is any better approach you think i should take please let me know : )

@JannikSt
Copy link
Copy Markdown
Member

Thank you for your contribution! :)
Can you rebase this PR off main and re-run formatting locally? I made some formatting adjustments as the line length of 88 was too short for a good dev-exp.

@JannikSt JannikSt requested a review from Copilot June 29, 2025 10:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling for interactive prompts by wrapping various user input sections in try/except blocks to catch cancellation events.

  • Added a top-level try block around the pod creation logic for API error handling.
  • Introduced try/except blocks for GPU selection, provider selection, configuration selection, pod name, disk size, vCPU, memory, image, and team ID prompts.
  • Wrapped the final pod creation confirmation to handle cancellation gracefully.

Comment thread src/prime_cli/commands/pods.py
@JannikSt
Copy link
Copy Markdown
Member

JannikSt commented Dec 3, 2025

Thank you for your contribution again! :) I've found a shorter approach here in #234 hence closing this one

@JannikSt JannikSt closed this Dec 3, 2025
@ved1beta ved1beta deleted the abort_error branch December 3, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aborts currently cause ugly exceptions

3 participants