add multimodal support#81
Open
nph4rd wants to merge 50 commits intoPrimeIntellect-ai:mainfrom
Open
Conversation
pass mm kwargs
|
Look like TRL support VLM natively now, any update here ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds multimodal support. Main changes are:
data_collator. I think this is useful because different VLMs have different processing requirements/tooling. For instance, in the case of Qwen, you can useqwen_vl_utilsto handle resizing, etc.format_oai_chat_msgfor the rollouts. This handles encoding them as base64 imgs for the API, but leaves the image objects for further processing later on.process_chat_formatnow has two branches: the multimodal case uses theprocessing_classto get the all the extra inputs necessary. These vary from model to model, so they are generically captured byremaining_inputs. I'm still unsure this is the best way to handle that, but this works.processing_class. This can now be either a multimodal processor (with thetokenizerattr) or a tokenizer in the text-only case.logits_to_keep. Not all models accept this.generic_model_loaderfunction to load models without handling specific classes (likeQwen2_5_VLForConditionalGeneration)AutoLigerKernelForCausalLMNotes: