ci: labeler workflow uses fork's own labeler.yml, not upstream#20
ci: labeler workflow uses fork's own labeler.yml, not upstream#20Marxist-Leninist wants to merge 1 commit intoPrismML-Eng:masterfrom
Conversation
|
Heads up: this PR's own labeler check is also failing, and that's expected — it's a GitHub Actions catch-22 with
Two ways forward:
Either way works. Option 1 is faster and makes this fork self-sufficient (no longer dependent on upstream's labeler.yml schema being v6-compatible). |
99a1cf3 to
f6dda6a
Compare
The workflow hard-coded `repository: ggml-org/llama.cpp` on its checkout step, so it always read upstream's labeler.yml regardless of what's in this fork. Upstream currently uses v5 `all:` composition syntax under `changed-files`, which actions/labeler@v6 rejects with: Unknown config options were under "changed-files": all Every PR to this fork has been failing the labeler check since the action was bumped to v6. Removing the hard-coded repository on the checkout step makes pull_request_target use its default (this fork's master), which already uses the correct v6 syntax. This decouples the fork from upstream's labeler.yml schema and unblocks CI without waiting for upstream to fix theirs.
f6dda6a to
5839493
Compare
|
This is only for the CI and actions? |
The labeler workflow hard-codes
repository: ggml-org/llama.cppon its checkout step, so it always reads upstream'slabeler.yml. Upstream uses v5all:composition syntax whichactions/labeler@v6rejects:Every PR to this fork has been failing the labeler check since the action was bumped to v6.
Drop the hard-coded
repository:so the checkout uses its default (this fork's master), which already has correct v6 syntax. Decouples the fork from upstream's labeler.yml schema.