Skip to content

Conversation

@rom1504bot
Copy link
Collaborator

@rom1504bot rom1504bot commented Oct 4, 2025

This automated PR sets up the relevant boilerplate for Minecraft pc version 1.21.9. Fixes #1095.

Related:

  • You can help contribute to this PR by opening a PR against this pc-1_21_9 branch instead of master.

@richnetdesign
Copy link

I can't reproduce this error when running cd tools/js && npm test locally from this branch. Also my # of tests run don't match the github actions output.

Locally I get

1663 passing (1m)
1 pending

Github says

1690 passing (2m)
1 pending
1 failing

  1. protocol yaml
    should be valid and in sync with json:
    Error: 1.21.8 (1.21.8) / protocol.json is desynced from yaml, please run 'npm run build'

I could use some advice on how to ensure my local environment testing matches the CI/CD

@extremeheat
Copy link
Member

Your local branch is out of date, it's not listing all the tests (1663 vs 1690). I just merged master into here, pull the latest commit and run it again

@richnetdesign
Copy link

richnetdesign commented Dec 5, 2025

Ok thanks. I regenerated the json and it found .8 and .9 were out of sync. I can submit a PR to fix.

It looks like the bot changed the .8 proto.yaml in this branch even though this PR is for .9. Is that correct?

This bot updates to .8 are here.
dd11e71

PR to fix is here
#1117

fixes 1.21.8 and 1.21.9

Co-authored-by: Rich Young <code@richyoung.ca>
@extremeheat
Copy link
Member

* Add loginPacket.json for Minecraft 1.21.9

Adds the missing loginPacket.json file needed for 1.21.9 server support.
Copied from 1.21.3 as they share similar login packet structure.

* adding ci.yml

* Refactor CI workflow for improved structure and clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Minecraft PC 1.21.9

5 participants