-
-
Notifications
You must be signed in to change notification settings - Fork 248
Updates to effects data, add data for Bedrock #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
can you add a pointer to this in the new version guide ? |
|
I see you deleted a bunch of effect file, can you
|
|
For the deleted files, I removed the files where there was no change from the previous version and just pointed the dataPath to the version that it was last changed |
|
I'm not sure convinced about deleting most version files usually we kept files for each versions but anyway can you at least resolve the conflict? |
|
@extremeheat should we merge this? |
I re added some of the unchanged JSONs
Yeah, I fixed the conflict, should be possible to merge now. |
|
Sorry conflict again. can you resolve it ? |
|
conflict + CI failing |
|
more conflict, @extremeheat let's try to finish this one |
|
Will check this out sometime this week, will need to also update the extractor for 1.20 |
808b341 to
5afdff2
Compare
5afdff2 to
a003a68
Compare
|
Did some work on this, but still need to continue working on script to handle all the versions correctly |
protocolName(name in registry),modifiersandcolorto effects datamodifierslist what attribute the effect modifies, the amount and the operation done (add/multiply)neutralas a category for effects, fix someneutraleffects being assignedbadtypeManually updated with script from mc source