Add skinUsesKeyedProperties #971
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extremeheat
approved these changes
Jan 22, 2025
extremeheat
requested changes
Jan 22, 2025
Member
extremeheat
left a comment
extremeheat
left a comment
There was a problem hiding this comment.
Actually... this is something we should fix in the data instead... can be added to work in #948
Author
|
@rom1504 approved the PR for mineflayer PrismarineJS/mineflayer#3548 so should that be undone? If you're wanting the fix to be done elsewhere (I think he did, I dunno, PRs still confuse me) |
Member
|
The PR you mention is not approved and also not merged. Do you mean another one ? |
Author
I confused myself cause you fixed my messup of multiple commits |
Member
|
@Pix3lPirat3 can you fix that directly in protocol.yml ? |
Member
|
I think this was fixed in #948. Is it still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
player_infopacket uses thekeyfield for skin properties instead ofname, Applies to Minecraft 1.19.3 and above.