fix: use node-rsa for decryption for higher node compatibility #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I wonder if this is still a problem or was fixed in Node.js, can you confirm latest node still doesn't work? |
Member
|
cc @u9g can you can check if on latest node this still happens and it's fixed by this PR? |
covyy
approved these changes
Dec 24, 2024
extremeheat
approved these changes
Dec 25, 2024
Contributor
Author
|
Sorry, I kind of forgot about this PR but it is still necessary in node v23 |
Member
|
/makerelease |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-rsato decrypt shared secrets and tokens becauseRSA_PKCS1_PADDINGis no longer supported in the latest node version