Re-introduce a Webhook endpoint to receive async updates#121
Merged
exarkun merged 12 commits intoPrivateStorageio:mainfrom Nov 2, 2022
Merged
Re-introduce a Webhook endpoint to receive async updates#121exarkun merged 12 commits intoPrivateStorageio:mainfrom
exarkun merged 12 commits intoPrivateStorageio:mainfrom
Conversation
Collaborator
|
Not sure if there's a corresponding OP ticket, but I think we should definitely do "signature verification" on all incoming webhooks (this or otherwise) before deploying for real. (github webhooks also have a signature header, didn't check how different it is to stripe's) |
Contributor
Author
|
That is what we are going to do. Unfortunately we have to implement it on our side or use another dependency implementing it. |
Collaborator
|
If there's a library, great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.