-
Notifications
You must be signed in to change notification settings - Fork 50
Implements default gateway flow #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e85bc93
Add default flow marker
caleeli fac19ae
Add default flow crown button
caleeli a1afcc5
Verify if flow can be the default
caleeli ba07b3a
Set default flow
caleeli 31d4764
Set/unset default flow
caleeli 1b1e10c
Fix reactivity for default flow on load xml
caleeli c75d4d2
Update src/components/nodes/node.js
caleeli f254063
Add method isDefaultFlow()
caleeli 944c369
Fix CR comments
caleeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| <template> | ||
| <crown-button | ||
| v-if="node.canBeDefaultFlow()" | ||
| :title="$t('Set as Default Flow')" | ||
| v-b-tooltip.hover.viewport.d50="{ customClass: 'no-pointer-events' }" | ||
| aria-label="Default Flow" | ||
| data-test="default-flow" | ||
| role="menuitem" | ||
| :src="icon" | ||
| @click="click" | ||
| /> | ||
| </template> | ||
|
|
||
| <script> | ||
| import CrownButton from '@/components/crown/crownButtons/crownButton'; | ||
| import icon from '@/assets/default-flow.svg'; | ||
|
|
||
| export default { | ||
| components: { CrownButton }, | ||
| props: ['node'], | ||
| data() { | ||
| return { | ||
| icon, | ||
| }; | ||
| }, | ||
| methods: { | ||
| click() { | ||
| this.$emit('default-flow', this.node); | ||
| }, | ||
| }, | ||
| }; | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused why you're deleting and re-adding it - could you give some overview why this needs to be done this way?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is to fix a weird issue when loading a process with a gateway with a defined "default" property, it is not reactive, then the user can not change the default flow. This could caused by way moddle loads this reference property