Run prepareData when the node definition changes#1284
Merged
boliviacoca merged 1 commit intodevelopfrom Dec 4, 2020
Merged
Conversation
danloa
approved these changes
Dec 4, 2020
vehikl-jacare
added a commit
that referenced
this pull request
Dec 9, 2020
PR #1284 introduces this code Co-Authored-By: Justin Struk <10167488+JStruk@users.noreply.github.com> Co-Authored-By: Robert Komaromi <chipit24@users.noreply.github.com> Co-Authored-By: Gerrie Swart <johnblackspear@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://processmaker.atlassian.net/browse/FOUR-2396
There are some inspectors like Task Assignments and Comments where we directly set the property on the node without going though the inspectorHandler. This caused those properties get reset when another property gets set using the inspectorHandler. This fix listens for changes on the node definition and makes sure they are set on the data object