Skip to content

FOUR-12505:Other script executor does not have an icon on the modal script list #5678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmPaulis merged 1 commit into from
Nov 22, 2023
Merged

FOUR-12505:Other script executor does not have an icon on the modal script list #5678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ProcessMaker/Models/ScriptExecutor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,10 @@ public static function list($language = null)
}

foreach ($executors->get() as $executor) {
$list[$executor->id] = $executor->language;
$list[$executor->id] = [
'language' => $executor->language,
'title' => $executor->title,
];
}

return $list;
Expand Down
20 changes: 15 additions & 5 deletions resources/js/processes/scripts/components/LanguageScript.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@
>
<b-card
:key="index"
:ref="`${lang}`"
:ref="`${lang.title}`"
class="mt-2"
@click="selectLanguage(lang, index)"
>
<b-card-text>
<img
:src="getImage(lang)"
:alt="lang"
:alt="lang.title"
>
<span class="text-uppercase ml-2">
{{ lang }}
{{ lang.language }}
</span>
</b-card-text>
</b-card>
Expand Down Expand Up @@ -59,7 +59,17 @@ export default {
* Get the Icon of the language
*/
getImage(lang) {
return `/img/script_lang/${lang}.svg`;
let srcImage = "";
switch (lang.language) {
case "php":
case "javascript":
case "lua":
srcImage = `/img/script_lang/${lang.language}.svg`;
break;
default:
srcImage = "/img/script_lang/default.svg";
}
return srcImage;
},
/**
* Add the border to the item selected
Expand All @@ -68,7 +78,7 @@ export default {
for (const item in this.$refs) {
this.$refs[item][0].className = "card mb-2 card-lang";
}
this.$refs[lang][0].className = "card mb-2 card-lang selected";
this.$refs[lang.title][0].className = "card mb-2 card-lang selected";
},
},
};
Expand Down