Skip to content

Set Admin User as Default run_as_user_id When Importing Scripts #6208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 2 commits into from
Feb 11, 2024
Merged

Set Admin User as Default run_as_user_id When Importing Scripts #6208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4492e35
Default to Admin User for Scripts without Assigned Run_as_user_id
sanjacornelius Feb 9, 2024
0387e9b
Optimize code to handle better edge cases
sanjacornelius Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ProcessMaker/ImportExport/Exporters/ScriptExporter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use ProcessMaker\ImportExport\DependentType;
use ProcessMaker\Models\EnvironmentVariable;
use ProcessMaker\Models\ScriptCategory;
use ProcessMaker\Models\User;

class ScriptExporter extends ExporterBase
{
Expand Down Expand Up @@ -35,7 +36,9 @@ public function import() : bool

foreach ($this->getDependents('user', true) as $dependent) {
$scriptUser = $dependent->model;
$this->model->run_as_user_id = $scriptUser->id;
// Assign the user ID to run the script
// If the user is not set in the dependent modal, default to the admin user
$this->model->run_as_user_id = $scriptUser?->id ?? User::where('is_administrator', true)->first()->id;
}

foreach ($this->getDependents('executor', true) as $dependent) {
Expand Down