Skip to content

observation/FOUR-14164 Update the mesagge design for empty results in Tasks tables #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 1 commit into from
Feb 16, 2024
Merged

observation/FOUR-14164 Update the mesagge design for empty results in Tasks tables #6228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions resources/js/components/common/DataLoading.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
<div class="empty-title">{{ emptyText() }}</div>
<div class="img-container">
<div v-if="emptyIconType() === 'beach'">
<img src="../../../img/no-results.svg" class="no-results-img" alt="no-results">
<img src="/img/no-results.svg" class="no-results-img" alt="no-results">
</div>
<div v-if="emptyIconType() === 'noData'">
<img src="../../../img/no-results.svg" class="no-results-img" alt="no-results">
<img src="/img/no-results.svg" class="no-results-img" alt="no-results">
</div>
<div v-if="emptyIconType() === 'noTasks'">
<img src="../../../img/no-tasks.svg" class="no-results-img" alt="no-results">
<img src="/img/all-cleared.svg" class="no-results-img" alt="no-results">
</div>
</div>
<p class="empty-desc">{{ emptyDescText() }}</p>
Expand Down
4 changes: 2 additions & 2 deletions resources/js/tasks/components/TasksList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@
<data-loading
v-show="shouldShowLoader"
:for="/tasks\?page|results\?page/"
:empty="$t('Well, it seems nothing in here')"
:empty-desc="$t('You don\'t currently have any tasks assigned to you')"
:empty="$t('All clear')"
:empty-desc="$t('No new tasks at this moment.')"
empty-icon="noTasks"
/>
<pagination-table
Expand Down
1 change: 1 addition & 0 deletions resources/lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,7 @@
"No files available for download": "No files available for download",
"No Loop Mode": "No Loop Mode",
"No new notifications at the moment.": "No new notifications at the moment.",
"No new tasks at this moment.": "No new tasks at this moment.",
"No Notifications Found": "No Notifications Found",
"no problems to report": "no problems to report",
"No Processes Available": "No Processes Available",
Expand Down