Skip to content

FOUR-16704: Session Token Not Invalidated on Logout #7396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 1 commit into from
Oct 2, 2024
Merged

FOUR-16704: Session Token Not Invalidated on Logout #7396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ProcessMaker/Http/Controllers/Auth/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\Cookie;
use Illuminate\Validation\ValidationException;
use Laravel\Passport\HasApiTokens;
use Laravel\Passport\Passport;
use ProcessMaker\Events\Logout;
use ProcessMaker\Http\Controllers\Controller;
use ProcessMaker\Managers\LoginManager;
Expand All @@ -19,6 +21,7 @@

class LoginController extends Controller
{
use HasApiTokens;
use HasControllerAddons;
/*
|--------------------------------------------------------------------------
Expand Down Expand Up @@ -239,6 +242,10 @@ protected function authenticated(Request $request, $user)
public function beforeLogout(Request $request)
{
if (Auth::check()) {
// Remove the Laravel cookie
$request->session()->invalidate();
Cookie::queue(Cookie::forget(Passport::cookie()));

//Clear the user permissions
$request->session()->forget('permissions');

Expand Down