FOUR-18606: Search text within the list of cases#7441
Merged
caleeli merged 12 commits intofeature/FOUR-18078from Oct 3, 2024
Merged
FOUR-18606: Search text within the list of cases#7441caleeli merged 12 commits intofeature/FOUR-18078from
caleeli merged 12 commits intofeature/FOUR-18078from
Conversation
caleeli
reviewed
Oct 2, 2024
caleeli
reviewed
Oct 2, 2024
| public function valueAliasStatus($value, $expression) | ||
| { | ||
| $statusMap = [ | ||
| 'in progress' => 'IN_PROGRESS', |
Contributor
There was a problem hiding this comment.
Use constants to handle this statuses. Create them if not exists.
ProcessRequest::REQUEST_STATUS_ACTIVE = 'ACTIVE';
CaseRepository::CASE_STATUS_ACTIVE = 'IN_PROGRESS';
Sync with @devmiguelangel to avoid conflict with PR #7445
caleeli
approved these changes
Oct 3, 2024
caleeli
approved these changes
Oct 3, 2024
devmiguelangel
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Implement the filterBy for the endpoint:
GET /api/1.1/cases/getAllCases
param
filterBy: [
{"subject":{"type":"Status"},"operator":"=","value":"In Progress"},
{"subject":{"type":"Field","value":"case_title"},"operator":"=","value":"234"}
]
Solution
How to Test
run the next test
php artisan test --filter CaseControllerTest
Related Tickets & Packages
Code Review Checklist
ci:next