Skip to content

FOUR-19583: Cyclical group assignment stops users from being able to login #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 3 commits into from
Jan 30, 2025
Merged

FOUR-19583: Cyclical group assignment stops users from being able to login #7769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44093d6
FOUR-19583
pmPaulis Nov 26, 2024
873dadd
Updating the code comments
pmPaulis Dec 2, 2024
c6981f7
Merge remote-tracking branch 'origin/release-2024-fall' into bugfix/F…
pmPaulis Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 29 additions & 12 deletions ProcessMaker/Traits/HasAuthorization.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@

namespace ProcessMaker\Traits;

use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\Log;
use ProcessMaker\Models\Group;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessPermission;
use ProcessMaker\Models\User;

trait HasAuthorization
{
Expand All @@ -32,27 +29,47 @@ public function loadUserPermissions()

public function loadGroupPermissions()
{
$processedGroups = [];
$permissions = [];

foreach ($this->groupMembersFromMemberable as $gm) {
$group = $gm->group;
$permissions = $this->loadPermissionOfGroups($group, $permissions);
$permissions = $this->loadPermissionOfGroups($group, $permissions, $processedGroups);
$names = $group->permissions->pluck('name')->toArray();
$permissions = array_merge($permissions, $names);
}

return $this->addCategoryViewPermissions($permissions);
}

public function loadPermissionOfGroups(Group $group, array $permissions = [])
public function loadPermissionOfGroups(Group $group, array $permissions = [], array $processedGroups = [])
{
foreach ($group->groupMembersFromMemberable as $member) {
$group = $member->group;
$permissions = $this->loadPermissionOfGroups($group, $permissions);
$permissions = array_merge($permissions, $group->permissions->pluck('name')->toArray());
}
try {
// Check if the group was proccessed
if (in_array($group->id, $processedGroups)) {
return $permissions;
}
// Add the group in the processedList
$processedGroups[] = $group->id;
// Load permissions
$groupPermissions = $group->permissions->pluck('name')->toArray();
$permissions = array_merge($permissions, $groupPermissions);
// Review groups
foreach ($group->groupMembersFromMemberable as $member) {
$memberGroup = $member->group;
$permissions = $this->loadPermissionOfGroups(
$memberGroup,
$permissions,
$processedGroups
);
}

return $permissions;
return array_unique($permissions);
} catch (\Exception $e) {
Log::error('Error loading group permissions: ' . $e->getMessage());

return $permissions;
}
}

public function hasPermission($permissionString)
Expand Down
83 changes: 83 additions & 0 deletions tests/Feature/PermissionsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,87 @@ public function testCreatePermission()

$this->assertDatabaseHas('permissions', $attributes);
}

public function testLoadsGroupPermissions()
{
// Create group and assign permission
$group = Group::factory()->create();
$permission = Permission::factory()->create(['name' => 'test-permission']);
$group->permissions()->attach($permission);
// Assign user in the group
$user = User::factory()->create();
GroupMember::factory()->create([
'member_type' => get_class($user),
'member_id' => $user->id,
'group_id' => $group->id,
]);
// Load permissions
$permissions = $user->loadGroupPermissions();
// Assert
$this->assertContains('test-permission', $permissions);
}

public function testLoadsNestedGroupPermissions()
{
// Create groups
$groupA = Group::factory()->create();
$groupB = Group::factory()->create();
// Create permissions
$permissionA = Permission::factory()->create(['name' => 'permission-a']);
$permissionB = Permission::factory()->create(['name' => 'permission-b']);
// Assign permissions to groups
$groupA->permissions()->attach($permissionA);
$groupB->permissions()->attach($permissionB);
// Make groupB member of groupA
GroupMember::factory()->create([
'member_type' => get_class($groupB),
'member_id' => $groupB->id,
'group_id' => $groupA->id,
]);
// Assign user in the group
$user = User::factory()->create();
GroupMember::factory()->create([
'member_type' => get_class($user),
'member_id' => $user->id,
'group_id' => $groupB->id,
]);
// Load permissions
$permissions = $user->loadGroupPermissions();
// Assert
$this->assertContains('permission-a', $permissions);
$this->assertContains('permission-b', $permissions);
}

public function testItHandlesCircularGroupPermissionsReferences()
{
// Create groups
$groupA = Group::factory()->create();
$groupB = Group::factory()->create();
// Create circular reference
GroupMember::factory()->create([
'member_type' => get_class($groupB),
'member_id' => $groupB->id,
'group_id' => $groupA->id,
]);
GroupMember::factory()->create([
'member_type' => get_class($groupA),
'member_id' => $groupA->id,
'group_id' => $groupB->id,
]);
// Create permissions
$permissionA = Permission::factory()->create(['name' => 'permission-a']);
$groupA->permissions()->attach($permissionA);
// Assign user in the group
$user = User::factory()->create();
GroupMember::factory()->create([
'member_type' => get_class($user),
'member_id' => $user->id,
'group_id' => $groupA->id,
]);
// Load permissions
$permissions = $user->loadGroupPermissions();
// Assert
$this->assertContains('permission-a', $permissions);
$this->assertNotNull($permissions);
}
}