Skip to content

Fix non-unique ids #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boliviacoca merged 3 commits into from
Aug 17, 2021
Merged

Fix non-unique ids #1039

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96bac9c
Fix non-unique ids
nolanpro Aug 16, 2021
d8756a8
Revert "Fix non-unique ids"
nolanpro Aug 16, 2021
f8d33a2
Ignore some vue-simple-uploader errors
nolanpro Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/components/renderer/file-upload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ import _ from 'lodash';
// Create the mixin
const uniqIdsMixin = createUniqIdsMixin();

// vue-simple-uploader tries to call these after the component has
// been destroyed since it does it in nextTick(). It has no effect
// on functionality because a new copy is created. TODO: Why is this
// component being recreated when used in a loop?
const ignoreErrors = [
'Cannot read property \'assignBrowse\' of null',
'Cannot read property \'assignDrop\' of null',
];

export default {
components: uploader,
mixins: [uniqIdsMixin],
Expand Down Expand Up @@ -84,6 +93,11 @@ export default {
this.$refs['uploader'].$forceUpdate();
}
},
errorCaptured(err) {
if (ignoreErrors.includes(err.message)) {
return false;
}
},
computed: {
required() {
if (this.config && this.config.validation) {
Expand Down