Skip to content

Bugfix Ticket 1052: Added validation for undefined id's before send a request (For 4.1) #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caleeli merged 3 commits into from
Oct 12, 2021
Merged

Bugfix Ticket 1052: Added validation for undefined id's before send a request (For 4.1) #1083

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32250ef
Added validation for undefined id's before send a request
agustinbusso Oct 12, 2021
619a0f8
Revert "Added validation for undefined id's before send a request"
agustinbusso Oct 12, 2021
5ec72c2
Added validation for undefined id before send a request
agustinbusso Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/DataProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ export default {
baseURL() {
return localStorage.getItem('baseURL');
},

// Methods below are used in the components

getTasks(params) {
const endpoint = _.get(window, 'PM4ConfigOverrides.getTasksEndpoint', '/tasks');
return this.get(endpoint + params).then(response => {
Expand Down Expand Up @@ -83,7 +83,8 @@ export default {
const cache = this.screensCache.find(screen => screen.id == id);
if (cache) {
resolve({data: cache});
} else {
}
if (!cache && id != undefined) {
const request = this.get(endpoint + `/${id}${query}`);
request.then(response => {
if (response.data.nested) {
Expand All @@ -94,7 +95,7 @@ export default {
}
});
},

postScript(id, params) {
let endpoint = _.get(
window,
Expand Down