Fix The "Required IF" validation doesn't works in Loop/Record List [FOUR-4132]#1094
Merged
Fix The "Required IF" validation doesn't works in Loop/Record List [FOUR-4132]#1094
Conversation
| loopField['$each'] = []; | ||
| const firstRow = this.data[0] || {}; | ||
| loopField['$each'] = {}; | ||
| const firstRow = (get(this.data, this.element.config.name) || [{}])[0]; |
Contributor
There was a problem hiding this comment.
the get from lodash has a default value if the conditional is not valid or the value is not present.
Docs: https://lodash.com/docs/4.17.15#get
Suggested change
| const firstRow = (get(this.data, this.element.config.name) || [{}])[0]; | |
| const firstRow = get(this.data, this.element.config.name, [{}][0]); |
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion, but I use || [{}] to cover the case in which get(this.data, this.element.config.name) is defined but is null
josechirivella
approved these changes
Oct 28, 2021
eiresendez
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://processmaker.atlassian.net/browse/FOUR-4132
Ticket: http://tickets.pm4overflow.com/tickets/1122
This PR based on #1089 includes: