Include vdata in nested calculated props#1133
Merged
ryancooley merged 1 commit intodevelopfrom Dec 18, 2021
Merged
Conversation
ryancooley
approved these changes
Dec 18, 2021
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce the problem:
screen: FOUR-4853.json.txt
Create a calculated prop called
outputwith jsreturn this.foo.one;Create a screen with an input name
foo.twoCreate a rich text that shows the
outputvariableGo to preview and add this example input data
Expected: output should show
oneActual result: no output
The problem is that the calculated props input data is not merged with the vdata.
Proposed solution is to merge those objects
Need to make sure this solution does not break the solution for https://processmaker.atlassian.net/browse/FOUR-2797