Merged
Conversation
agustinbusso
approved these changes
Feb 24, 2022
Contributor
agustinbusso
left a comment
There was a problem hiding this comment.
Working well, no errors in console showing now and screen do not freezes.
Screen.Recording.2022-02-24.at.10.57.01.mov
ryancooley
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Two previous tickets are affected by this PR:
https://processmaker.atlassian.net/browse/FOUR-5420
https://processmaker.atlassian.net/browse/FOUR-4853
Steps to reproduce for FOUR-5420:
Expected behavior:
The screen should displayed without problems
Current behavior:
the screen will or halt or a console error will be printed saying " infinite loop detect with form_date_picker_1"
Steps to reproduce for FOUR-4853:
FOUR-4853.json.txt
{
"foo": {
"one": "one",
"two": "two"
}
}
Expected behavior:
The second input should display "one"
Actual behavior:
The second input is left empty
Solution
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-5420
Code Review Checklist