Skip to content

Bugfix/four 5420#1188

Merged
ryancooley merged 2 commits intodevelopfrom
bugfix/FOUR-5420
Feb 25, 2022
Merged

Bugfix/four 5420#1188
ryancooley merged 2 commits intodevelopfrom
bugfix/FOUR-5420

Conversation

@danloa
Copy link
Copy Markdown
Contributor

@danloa danloa commented Feb 23, 2022

Issue & Reproduction Steps

Two previous tickets are affected by this PR:
https://processmaker.atlassian.net/browse/FOUR-5420
https://processmaker.atlassian.net/browse/FOUR-4853

Steps to reproduce for FOUR-5420:

  • Import the process Process Calc.json.txt
  • Create a new request of the process above. Open the first task

Expected behavior:
The screen should displayed without problems
Current behavior:

the screen will or halt or a console error will be printed saying " infinite loop detect with form_date_picker_1"

Steps to reproduce for FOUR-4853:

  • Import the screen
    FOUR-4853.json.txt
  • Create a calculated prop called output with js return this.foo.one;
  • Create a screen with an input name foo.two
  • Create a rich text that shows the output variable
  • Go to preview and add this example input data

{
"foo": {
"one": "one",
"two": "two"
}
}

Expected behavior:
The second input should display "one"

Actual behavior:
The second input is left empty

Solution

  • invlude the attribute vdata just when it is different from the one stored in the object 'this'

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-5420

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, no errors in console showing now and screen do not freezes.

Screen.Recording.2022-02-24.at.10.57.01.mov

@ryancooley ryancooley merged commit b65fce5 into develop Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants