Update CI #33

malberts · 2025-02-25T13:06:37Z

Summary by CodeRabbit

Chores
- Enhanced the testing pipeline to better manage experimental runs with improved error tolerance.
- Expanded compatibility testing to cover additional platform versions for more robust quality assurance.
Bug Fixes
- Updated the method for constructing page titles in tests to improve property ID representation.
Style
- Reformatted arrow function syntax for consistency across various methods.
- Adjusted exception handling formatting for improved readability.
Documentation
- Updated platform requirements in the README to reflect new version compatibility for PHP, MediaWiki, and Wikibase.

coderabbitai · 2025-02-25T13:10:10Z

📝 Walkthrough

Walkthrough

The changes update the CI workflow configuration by adding an experimental field to the job matrix in the test job defined in the CI workflow file. This field is used to set the continue-on-error property based on whether the configuration is marked as experimental. Additionally, new matrix entries have been introduced for recent MediaWiki versions with respective PHP versions, designating the master branch as experimental while others remain non-experimental. Other changes include the removal of a testsuite from the PHPUnit configuration and various formatting adjustments in the codebase.

Changes

File	Change Summary
.github/.../ci.yml	Introduced an `experimental` field in the job matrix for the `test` job; updated `continue-on-error` to reference this field; added new matrix entries for MediaWiki versions (REL1_41, REL1_42, REL1_43, master) with proper PHP versions and experimental settings.
phpunit.xml.dist	Removed testsuite declaration for "TestExampleRules".
src/DataAccess/...Fetcher.php	Reformatted exception handling in `getPageContent` method without changing functionality.
src/DataAccess/...Deserializer.php	Reformatted arrow function syntax in `newEntityCriteria` method without changing functionality.
src/Domain/...Template.php	Reformatted arrow function syntax in `supportsMultipleValues` and `buildMultipleValues` methods without changing functionality.
src/Domain/...TemplateSegment.php	Reformatted lambda function syntax in `getValuesForSegment` method without changing functionality.
src/Hooks.php	Reformatted exception handling in `onMultiContentSave` method without changing functionality.
tests/MediaWiki/...MwTestCase.php	Modified `saveProperty` method to change the method used for constructing the page title from `serialize()` to `getSerialization()`.
README.md	Updated platform requirements section to reflect new version numbers for PHP (up to 8.3), MediaWiki (up to 1.43), and Wikibase (up to 1.43).

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

README.md (1)
189-191: Update platform requirements and markdown list formatting

The updated platform requirements correctly reflect the new compatibility targets—PHP now shows "7.4 or later (tested up to 8.3)" and MediaWiki/Wikibase now indicate "1.35 or later (tested up to 1.43)". This change aligns with the CI configuration updates described in the PR objectives.

Additionally, please consider changing the unordered list markers from asterisks (*) to dashes (-) to comply with markdownlint guidelines (MD004). This adjustment improves consistency and readability of the documentation.
- * [PHP] 7.4 or later (tested up to 8.3)
- * [MediaWiki] 1.35 or later (tested up to 1.43)
- * [Wikibase] 1.35 or later (tested up to 1.43)
+ - [PHP] 7.4 or later (tested up to 8.3)
+ - [MediaWiki] 1.35 or later (tested up to 1.43)
+ - [Wikibase] 1.35 or later (tested up to 1.43)
🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

189-189: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

190-190: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

191-191: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5d62b5 and 7e6499b.

📒 Files selected for processing (1)

README.md (1 hunks)

🧰 Additional context used

🪛 markdownlint-cli2 (0.17.2)

README.md

189-189: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

190-190: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

191-191: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

JeroenDeDauw · 2025-02-25T20:09:41Z

README.md

-* [PHP] 7.4 or later (tested up to 8.0)
-* [MediaWiki] 1.35 or later (tested up to 1.37)
-* [Wikibase] 1.35 or later (tested up to 1.37)
+* [PHP] 7.4 or later (tested up to 8.3)


Shouldn't this be 8.4?

Technically CI on MW master passes on 8.4 today. I'm slightly unsure if we should add that as official support yet. Or maybe that's good enough.

Update CI

e7a6054

malberts added 4 commits February 25, 2025 15:35

Remove missing test suite

1f1130a

Replace serialize method

11b0dfb

Fix CS

c5d62b5

Update readme

7e6499b

coderabbitai bot reviewed Feb 25, 2025

View reviewed changes

JeroenDeDauw merged commit 72cda99 into master Feb 25, 2025
23 checks passed

JeroenDeDauw deleted the malberts-patch-1 branch February 25, 2025 20:05

JeroenDeDauw reviewed Feb 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update CI #33

Update CI #33

Uh oh!

malberts commented Feb 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

JeroenDeDauw Feb 25, 2025

Uh oh!

malberts Feb 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Update CI #33

Update CI #33

Uh oh!

Conversation

malberts commented Feb 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JeroenDeDauw Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

malberts Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

malberts commented Feb 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)