Front End: Added delta chart and delta settings#117
Conversation
Also added a reload button and changed call structure a bit for easier data updating
(Hopefully) improved type-checking logic, naming and some comments for the code.
fabiancdng
left a comment
fabiancdng
left a comment
There was a problem hiding this comment.
Just pushed some minor changes regarding naming conventions and added a few comments, hope that's okay. Besides that, everything seems to work for me. Looks good! Hope the performance will be okay on every device as there are a lot of calculations happening on the front end this way. However, due to the specifiable interval between records (which I quite like) it's probably not possible to calculate them in advance and store in the DB or something... So I think for now it's the best solution.
|
Chrome's performance analysis reports that all charts take a breathtaking 0.9 ms to draw and the delta chart takes 0.2 ms. I think that is tolerable. And since the dataset already exists in memory and the delta data isn't that big it also isn't a problem of ram. |
2 participants
Closes #113
Closes #115
Please have a look.
I also don't know where to merge this. I hope master works. You will have to discard your changes to the delta function when frontend-enhancements gets merged, however.