Conversation
changed message a bit (e.g. to include feed)
fabiancdng
left a comment
There was a problem hiding this comment.
Feeds and subscriptions seem to work for me!
I really like your DB code refactor. Using a connection pool is certainly the best way of implementing MySQL for our use case.
Just to make sure I understand it correctly: This PR introduces the core functionalities of a notification system but it doesn't put any content in the feed or send out notifications?
Do you plan on implementing the triggers and content before merging into master or do you want (us) to do that afterwards? I'd be totally fine with contributing to that
|
Yep, you got it. This just implements the means to create the feeds and send them via Telegram. If you want, you may start adding triggers for the admin feed. The data feed needs some further coding because sending it every 30 minutes would be a bit much. I'm excited about your changes :) |
|
Oh, and since you are the front-end guy for the most part: I am thinking about a super-simplified forum layout. There should be a back button that leads back to the main feed. |
Thanks for your explanation! I agree, sending out a Telegram notification every time a new data set has been measured is annoying af. Do you think something like a "summary" would make sense? So, something like sending out a notification once a day that tells you how many data sets were captured on that day (maybe with average values?) and maybe points you to the detailed RSS feed? |
I'm not at all into RSS feeds and stuff. But I'll try my best to come up with something when I get to it. |
|
@AuxiliumCDNG Made the PR WIP for now (unless your want to merge the current changes already?). I also updated your PR description and added a to-do list. I might be busy and not able to work on this project for a while. But I'll try to get to it ASAP. |
You don't need to. You already get the Item with its title, text, time, and feed name. You just need to display it. |
Yep, that's what I was thinking...I will remove that from the todo for now and put it into a seperate issue. |
# Conflicts: # app.py
Add ability to retrieve a feed in different formats. There's a classic RSS (XML) option, a JSON option and an HTML option utilizing the Feed Template.
23d1ec9 to
89fa6a3
Compare
Add HTML template for a single feed article. Also, rename `rss.html` to `feed.html`.
Add ability to retrieve a feed article in different formats. There's a JSON option and an HTML option utilizing the feed article template.
|
@AuxiliumCDNG I worked a little on the templating stuff and here is what I came up with: FeedsEach feed can now be retrieved in 3 different formats: XML (so that RSS readers can properly parse it), JSON (so we can easily use it in other projects; maybe a display implementation?) and HTML. The HTML version has a template applied so it's human-readable and sort of "interactive". You can specify the different formats by appending Single ArticlesI also created JSON and HTML versions for "single" articles (using the same URL params). However, by default it only returns the article's text (since I couldn't figure out how to get a single post in RSS/XML format from the Notifications class, maybe you can try to implement that?). |
|
Oh, and as you can see in the screenshot, there's now an event pushed to the admin feed when the |
|
Single RSS posts don't have any formatting. They just get opened by the link they got associated with. |
|
Done! Also, please add some link on the dashboard and display so people find it? :) |
|
Oh, and this... |
Add "index" page for feeds with link to each feed alongside some info about the feed.
|
@AuxiliumCDNG Nice idea with the QR code! Added main page for feed with list of all feedAdded QR code to RSS feed at the top of the HTML versionsThe QR code is dynamically generated using a client-side API. That means the URL isn't hard-coded so the QR code will always point to the correct domain regardless of where and how BeeLogger is deployed. Added Iframe on Display page and Link(s) on Dashboard |
TODO: Implement proper check system
|
I think we should merge this for now. I added a trigger for the warning feed. |
fabiancdng
left a comment
There was a problem hiding this comment.
@AuxiliumCDNG Looks good and I agree. Feel free to merge.




This closes #54.
I added three "feeds":
admin - contains software and hardware related alerts
warning - contains notifications regarding the bees themselves
data - contains live datasets of the API
They may be viewed with an RSS client via
/rss/<feed>and/rss/<feed>/<post>.They are also sent via Telegram if you have subscribed to them, which may be done by sending
/aboniere_<feed>.Problems:
Have fun :)