Skip to content

Conversation

@crayolakat
Copy link
Collaborator

@crayolakat crayolakat commented Mar 23, 2023

Description

When I created bug reports in the past, I was confused what "version" was referring to, and was filling out browser version for this field. After speaking to the creator of this file, I realized that "version" refers to Spoke version. The changes in this PR clarifies that "version" refers to Spoke version, and as an example gives a Spoke version that exists.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • [] The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@crayolakat
Copy link
Collaborator Author

The failing rediscache tests are unrelated to the changes in this PR.

@crayolakat crayolakat added the S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc label Dec 8, 2023
@crayolakat crayolakat mentioned this pull request Dec 8, 2023
@crayolakat crayolakat added S-testing-on-stage Status (ADMINS ONLY): PR label for presence on a staging instance and removed S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc labels Dec 8, 2023
@crayolakat crayolakat mentioned this pull request Jan 12, 2024
@crayolakat crayolakat mentioned this pull request Mar 8, 2024
@engelhartrueben engelhartrueben changed the base branch from main to stage-main-14.1 July 10, 2024 17:56
@engelhartrueben engelhartrueben merged commit cd105b4 into stage-main-14.1 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-testing-on-stage Status (ADMINS ONLY): PR label for presence on a staging instance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants