-
Notifications
You must be signed in to change notification settings - Fork 411
make redis tests work #2359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make redis tests work #2359
Conversation
* The excluded UI tests don't use server components * We need `@jest-environment jsdom` for testing UI components where we mount react components but it doesn't include setImmediate. The Redis client needs setImmediate which is available when we use `@jest-environment node` but then we can't mount react components. One size does not fit all!
|
Hey Larry, Just want to first thank you for working on this! Absolute life saver!
|
mau11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
If you have a second @mau11 , my last commit needs to be removed. No point in extending the jest timeout since that was never the problem. I can get to it later tonight if not! |
|
@engelhartrueben I changed the timeout back to 15000 |
I can't leave it this way but let's see if it works
c8b7162 to
707c3a3
Compare
33bfcab to
7f6c80c
Compare
|
🎉🎉🎉 |
Fixes # (issue)
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP
Checklist: