-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add device filtering for GPU selection #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @Lion916! It looks like this is your first PR to Project-HAMi/volcano-vgpu-device-plugin 🎉 |
|
@archlitchi could you please take a look at this PR when you have a moment? Thanks! |
|
Looks like it's a feature, could you provide some document of example about how to use it? |
c886359 to
98fc771
Compare
|
Drawing inspiration from HAMi's per-node GPU filtering via ConfigMap, I have implemented the complete feature that was missing in volcano-vgpu-device-plugin. The implementation has been fully integrated and documented in doc/config.md. cc @archlitchi |
|
@archlitchi @SataQiu could you please take a look at this PR when you have a moment? Thanks! |
SataQiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/lgtm
|
@archlitchi could you please take a look at this PR when you have a moment? Thanks! |
archlitchi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The build pipeline failed, and the logs indicate that the issue is related to insufficient disk space on the build agent. Could you please investigate and assist with resolving the storage limitation? @SataQiu |
OK, let's fix it. |
|
please rebase the PR, the CI has been fixed |
|
@archlitchi @SataQiu I've already rebased, please take another look. |
Signed-off-by: wangshuai <1090646861@qq.com>
5397949 to
e7d4347
Compare
archlitchi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, Lion916 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |

Problem Solved
Support device filtering in Volcano HAMI scenarios, enabling volcano-device-plugin to exclude non-virtualization-capable GPUs from nodes based on ConfigMap configuration.