Skip to content

Conversation

@Lion916
Copy link

@Lion916 Lion916 commented Oct 31, 2025

Problem Solved

Support device filtering in Volcano HAMI scenarios, enabling volcano-device-plugin to exclude non-virtualization-capable GPUs from nodes based on ConfigMap configuration.

@hami-robot
Copy link
Contributor

hami-robot bot commented Oct 31, 2025

Welcome @Lion916! It looks like this is your first PR to Project-HAMi/volcano-vgpu-device-plugin 🎉

@hami-robot hami-robot bot added the size/M label Oct 31, 2025
@Lion916
Copy link
Author

Lion916 commented Nov 4, 2025

@archlitchi could you please take a look at this PR when you have a moment? Thanks!

@archlitchi
Copy link
Member

Looks like it's a feature, could you provide some document of example about how to use it?

@Lion916 Lion916 force-pushed the feature/filterdevice branch 2 times, most recently from c886359 to 98fc771 Compare November 7, 2025 00:57
@Lion916
Copy link
Author

Lion916 commented Nov 7, 2025

Drawing inspiration from HAMi's per-node GPU filtering via ConfigMap, I have implemented the complete feature that was missing in volcano-vgpu-device-plugin. The implementation has been fully integrated and documented in doc/config.md. cc @archlitchi

@Lion916
Copy link
Author

Lion916 commented Nov 13, 2025

@archlitchi @SataQiu could you please take a look at this PR when you have a moment? Thanks!

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

/lgtm

@hami-robot hami-robot bot added the lgtm label Nov 14, 2025
@Lion916
Copy link
Author

Lion916 commented Nov 21, 2025

@archlitchi could you please take a look at this PR when you have a moment? Thanks!

Copy link
Member

@archlitchi archlitchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Lion916
Copy link
Author

Lion916 commented Dec 3, 2025

image

The build pipeline failed, and the logs indicate that the issue is related to insufficient disk space on the build agent. Could you please investigate and assist with resolving the storage limitation? @SataQiu

@SataQiu
Copy link
Member

SataQiu commented Dec 7, 2025

The build pipeline failed, and the logs indicate that the issue is related to insufficient disk space on the build agent. Could you please investigate and assist with resolving the storage limitation? @SataQiu

OK, let's fix it.

@archlitchi
Copy link
Member

please rebase the PR, the CI has been fixed

@hami-robot hami-robot bot removed the lgtm label Dec 24, 2025
@Lion916
Copy link
Author

Lion916 commented Dec 24, 2025

@archlitchi @SataQiu I've already rebased, please take another look.

Signed-off-by: wangshuai <1090646861@qq.com>
@Lion916 Lion916 force-pushed the feature/filterdevice branch from 5397949 to e7d4347 Compare December 24, 2025 02:39
@Lion916 Lion916 requested a review from archlitchi December 24, 2025 03:20
Copy link
Member

@archlitchi archlitchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot hami-robot bot added the lgtm label Dec 26, 2025
@hami-robot
Copy link
Contributor

hami-robot bot commented Dec 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, Lion916

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot bot merged commit df5343d into Project-HAMi:main Dec 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants