This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Sequence Ordering class #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Warvito
suggested changes
Feb 5, 2023
Collaborator
Warvito
left a comment
Warvito
left a comment
There was a problem hiding this comment.
The code looks good. The unit tests require a few changes. I pushed a few automatic corrections.
tests/test_ordering.py
Outdated
Comment on lines
281
to
284
| @parameterized.expand(TEST_ORDERING_FAILURE) | ||
| def test_failure(self, input_param): | ||
| with self.assertRaises(ValueError): | ||
| Ordering(**input_param) |
Collaborator
There was a problem hiding this comment.
Please use more descriptive and separated tests for the failure cases. If one of them fails, it is hard to findout what part of the code it was testing.
Warvito
approved these changes
Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the sequence Ordering classes used in @Warvito's anomaly detection.