This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Add causal self-attention block #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Collaborator
Author
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
marksgraham
approved these changes
Mar 13, 2023
Collaborator
marksgraham
left a comment
marksgraham
left a comment
There was a problem hiding this comment.
Looks good, just a fix to the import and typing
| else: | ||
| self.mask = None | ||
|
|
||
| def forward(self, x): |
Collaborator
There was a problem hiding this comment.
Typing missing from forward
| from monai.networks import eval_mode | ||
| from parameterized import parameterized | ||
|
|
||
| from generative.networks.blocks.selfattention import SABlock |
Collaborator
There was a problem hiding this comment.
Do you think we should use an __init__.py file so we can have the nicer
from generative.networks.blocks import SABlock?
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Warvito
deleted the
196-add-self-attention-block-for-autoregressive-transformer
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196