Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Conversation

@Warvito
Copy link
Collaborator

@Warvito Warvito commented Feb 9, 2023

Fixes #234

Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito linked an issue Feb 9, 2023 that may be closed by this pull request
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Copy link

@jehig jehig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Please may I ask if is this update expected to fix the "TypeError: 'int' object is not subscriptable" error in the VQVAE tutorials?
Thanks, Jack

Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
Copy link
Collaborator Author

Warvito commented Feb 9, 2023

Hi, Please may I ask if is this update expected to fix the "TypeError: 'int' object is not subscriptable" error in the VQVAE tutorials? Thanks, Jack

Hi @jehig ! Sorry, we were actually fixing the error found in #234 (related to the length of num_channels and the num_levels value) and for that we are re-running the vqvae tutorials.
Sorry for not catching the error that you mentioned before, could you please send more info on where in the tutorial this is happening? is this happening with the updated version installed?

@jehig
Copy link

jehig commented Feb 9, 2023

Thanks for your quick response! The model is training now after I changed num_channels and num_res_channels input to tuples, as the tutorial script was out of date.
Note I did install the GenerativeModels project today, so the tutorial on git could still be out of date...

@Warvito Warvito marked this pull request as ready for review February 10, 2023 00:16
@Warvito Warvito changed the title 234 update vq vae tutorials based on model input requirements Change num_res_channels and num_channels to Sequence[int] | int Feb 10, 2023
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito merged commit 00e7bb7 into main Feb 10, 2023
@Warvito Warvito deleted the 234-update-vq-vae-tutorials-based-on-model-input-requirements branch February 10, 2023 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update VQ-VAE tutorials based on model input requirements

4 participants