This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Adding tutorial on 2D super resolution using lightning #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksgraham
suggested changes
May 2, 2023
Collaborator
marksgraham
left a comment
marksgraham
left a comment
There was a problem hiding this comment.
Looks good - some small changes around imports. Could you also fix formatting by running ./runtests.sh --autofix
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Show resolved
Hide resolved
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Outdated
Show resolved
Hide resolved
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Outdated
Show resolved
Hide resolved
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Outdated
Show resolved
Hide resolved
ericspod
reviewed
May 12, 2023
...rials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.ipynb
Outdated
Show resolved
Hide resolved
ericspod
reviewed
May 12, 2023
...rials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.ipynb
Outdated
Show resolved
Hide resolved
ericspod
reviewed
May 12, 2023
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Outdated
Show resolved
Hide resolved
ericspod
reviewed
May 12, 2023
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Outdated
Show resolved
Hide resolved
…2_super_resolution-lightning.ipynb Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
…2_super_resolution-lightning.py Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
…2_super_resolution-lightning.py Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
ericspod
reviewed
May 15, 2023
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Outdated
Show resolved
Hide resolved
ericspod
reviewed
May 15, 2023
...rials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.ipynb
Outdated
Show resolved
Hide resolved
ericspod
reviewed
May 15, 2023
...rials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.ipynb
Outdated
Show resolved
Hide resolved
ericspod
reviewed
May 15, 2023
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py
Outdated
Show resolved
Hide resolved
…2_super_resolution-lightning.py Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
…2_super_resolution-lightning.ipynb Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
…2_super_resolution-lightning.ipynb Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
…2_super_resolution-lightning.ipynb Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
…2_super_resolution-lightning.py Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
marksgraham
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on issue #364.