Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Conversation

@mingxin-zheng
Copy link
Contributor

Fix #386

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
@mingxin-zheng mingxin-zheng requested a review from Warvito May 18, 2023 04:39
@ericspod
Copy link
Member

We do need to change the requirements mentioned in setup.py as well. With that changed this should work, though I'd suggest we reorganise things in the future to use pyproject.toml exclusively to define dependencies. I point people to RandomDataset as an example of setting up a repo like this which I think is the more modern way.

@Warvito
Copy link
Collaborator

Warvito commented May 18, 2023

As @ericspod mentioned, it is necessary to change the following line to update the deps

install_requires=["monai-weekly==1.2.dev2304"],

I also agree with Eric regarding the future reorganisation of setup.py and pyproject.toml to be more similar to the other monai packages and randomDataset. I will create an issue for that

@ericspod
Copy link
Member

We might want to bump version to 0.2.2 with these fixes as well so that the changes in tutorials can reference that fixed version.

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
@mingxin-zheng
Copy link
Contributor Author

Thank you @ericspod @Warvito for the comments. Just updated the PR accordingly.

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the version bump and we can merge.

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito merged commit a747e72 into Project-MONAI:main May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed MONAI version in requirements may disrupt developer's environment

3 participants