This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Add FID #40
Merged
Add FID #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
danieltudosiu
approved these changes
Jan 23, 2023
Contributor
danieltudosiu
left a comment
danieltudosiu
left a comment
There was a problem hiding this comment.
Looks good. My only question is why should we maintain it instead of making it work within the PiQ requirements. Since it is solely based on it.
Collaborator
Author
|
I guess, since we are using a small feature of the piq package, it would be better add just this part instead adding the whole package as an optional dependency. The package also includes implementations of MSSSIM and other metrics that we alrady have available at MONAI and could put in question why not just use the dependency too. Also, it could make it more flexible depending on how we adopt thhe feature extractors as we discussed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement (#35)