Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

373 add code for spade vae gan #405

Merged
marksgraham merged 7 commits into from
Jul 5, 2023
Merged

373 add code for spade vae gan #405

marksgraham merged 7 commits into from
Jul 5, 2023

Conversation

@virginiafdez
Copy link
Contributor

@virginiafdez virginiafdez commented Jun 22, 2023

  • Added support for SPADE-GAN network (SPADE normalisation and GAN-VAEGAN-like generator)
  • Added unit tests
  • Added tutorial for 2D usage of SPADE-GAN along with Multi-Scale Discriminator.

@virginiafdez virginiafdez linked an issue Jun 22, 2023 that may be closed by this pull request
Add code for SPADE VAE-GAN #373
Closed
@Warvito
Add tutorial outputs
e77599e 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@virginiafdez virginiafdez marked this pull request as ready for review June 26, 2023 12:19
marksgraham
marksgraham suggested changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@marksgraham marksgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Looks good! Some changes requested in the comments

generative/networks/nets/spade_network.py
x_s = x
return x_s

class SPADE_Encoder(nn.Module):
Copy link
Collaborator

@marksgraham marksgraham Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstrng here too

Implemented changes as per PR correction: adding docstrings, removing…
067998b 
… blank lines, modifying the notebook to take losses more into account + conclusion.
@virginiafdez
Copy link
Contributor Author

virginiafdez commented Jul 5, 2023

Added requested changes:

  • Added more info to the tutorial and loss plot
  • Removed blank lines
  • Added docstrings

@marksgraham marksgraham merged commit 72f0e5d into main Jul 5, 2023
@marksgraham marksgraham deleted the 373-add-code-for-spade-vae-gan branch December 21, 2023 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@marksgraham marksgraham marksgraham approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add code for SPADE VAE-GAN

4 participants

@virginiafdez @marksgraham @Warvito