This repository was archived by the owner on Feb 7, 2025. It is now read-only.
add spatial rescaler #414
Merged
add spatial rescaler #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guopengf
requested review from
Can-Zhao,
dongyang0122,
ericspod and
marksgraham
marksgraham
suggested changes
Aug 4, 2023
marksgraham
suggested changes
Aug 11, 2023
Collaborator
marksgraham
left a comment
marksgraham
left a comment
There was a problem hiding this comment.
Thanks, looks good to me - just one minor docstring change I noticed!
| n_stages: number of interpolation stages. | ||
| size: output spatial size (int or Tuple[int] or Tuple[int, int] or Tuple[int, int, int]). | ||
| method: algorithm used for sampling. | ||
| multiplier: multiplier for spatial size. If scale_factor is a tuple, |
Collaborator
There was a problem hiding this comment.
this part about scale_factor doesn't make sense - there is no variable with that name, and multiplier can't be a tuple. maybe just delete the part about scale_factor?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing out the docstring problem. I have fixed it. This remembers me that the multiplier can be a Sequence[float]. I already added this type and a new test case for this situation in the latest commit.
marksgraham
approved these changes
Aug 14, 2023
Collaborator
marksgraham
left a comment
marksgraham
left a comment
There was a problem hiding this comment.
Looks great, thanks for the addition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the discussion at #410 and add the spatial rescaler implementation.