tests.test_wsireader unclosed file

[wyli]

2022-11-03T08:33:03.4930436Z test_read_malformats_0 (tests.test_wsireader.TestTiffFileDeprecated) ... ok
2022-11-03T08:33:03.4941640Z test_read_malformats_1 (tests.test_wsireader.TestTiffFileDeprecated) ... ok
2022-11-03T08:33:03.4983021Z test_read_malformats_2 (tests.test_wsireader.TestTiffFileDeprecated) ... unclosed file <_io.FileIO name='/home/runner/work/MONAI/MONAI/tests/testing_data/temp_CMU-1.tiff.tiff' mode='rb' closefd=True>
unclosed file <_io.BufferedReader name='/home/runner/work/MONAI/MONAI/tests/testing_data/temp_CMU-1.tiff.tiff'>
2022-11-03T08:33:04.4968625Z unclosed file <_io.FileIO name='/home/runner/work/MONAI/MONAI/tests/testing_data/temp_CMU-1.tiff.tiff' mode='rb' closefd=True>

log: https://github.com/Project-MONAI/MONAI/actions/runs/3379844814/jobs/5612814925 (probably this is introduced much earlier, I only noticed just now)

cc @drbeh

[bhashemian]

Hi @wyli, you are right, it has been there from before. The issue comes from the test when using tifffile with LoadImage since LoadImage has first select the reader and create the object and then use the object separately. This mean that the image object is not being closed. I will submit a PR to fix this in LoadImage.

[bhashemian]

Closed as it is only a warning and happens in a specific situation so it is not worth to change the API for it.

[wyli]

this is not addressed yet, I think we keep this open so the other contributors may provide a good solution.